Updating release-winget according to manifest schema changes #332
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,26 +7,29 @@ jobs: | |
| release: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - id: update-winget | ||
| name: Update winget repository | ||
| uses: mjcheetham/update-winget@v1.2 | ||
| with: | ||
| id: Microsoft.GitCredentialManagerCore | ||
| token: ${{ secrets.WINGET_TOKEN }} | ||
| releaseAsset: gcmcore-win-x86-(.*)\.exe | ||
| manifestText: | | ||
| PackageIdentifier: {{id}} | ||
| PackageVersion: {{version}} | ||
| PackageName: Git Credential Manager Core | ||
| Publisher: Microsoft Corporation | ||
| Moniker: git-credential-manager-core | ||
| PackageUrl: https://aka.ms/gcmcore | ||
| Tags: [ gcm, gcmcore, git, credential ] | ||
| License: Copyright (C) Microsoft Corporation | ||
| ShortDescription: Secure, cross-platform Git credential storage with authentication to GitHub, Azure Repos, and other popular Git hosting services. | ||
|
There was a problem hiding this comment. Is there now a longer There was a problem hiding this comment.
There was a problem hiding this comment. Is there anything specific we'd want to call out in a longer There was a problem hiding this comment. I think we can wait on |
||
| Installers: | ||
| - Architecture: x86 | ||
| InstallerUrl: {{url}} | ||
| InstallerType: inno | ||
| InstallerSha256: {{sha256}} | ||
| PackageLocale: en-US | ||
| ManifestType: singleton | ||
| ManifestVersion: 1.0.0 | ||
| alwaysUsePullRequest: true | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we still want
repo: microsoft/winget-pkgs, right? Or, is that built-in tov1.2?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's the default! However, we can keep if it's better to be explicit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Using the default works for me.
This comment was marked as spam.
Sorry, something went wrong.