Show Bitbucket Server/Data Center URL in UI and use better help links #713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the Bitbucket credential UI to show the URL of the Bitbucket Server or Data Center instance, if we're talking to them. Also fix up the help links to point to a host-relative location; not always to Bitbucket Cloud pages. Note that the OAuth prompt will never been shown for Server/DC since 2FA is not supported there.
ldennington
approved these changes
May 26, 2022
| @@ -30,17 +30,18 @@ public OAuthViewModel(IEnvironment environment) | |||
|
|
|||
| private void LearnMore() | |||
| { | |||
| BrowserUtils.OpenDefaultBrowser(_environment, "https://confluence.atlassian.com/bitbucket/two-step-verification-777023203.html"); | |||
| // 2FA is not supported on Server/DC so this prompt will never be seen outside of Bitbucket Cloud | |||
|
How does it display with |
mminns
approved these changes
May 26, 2022
| @@ -94,6 +94,11 @@ public async Task<CredentialsPromptResult> GetCredentialsAsync(Uri targetUri, st | |||
| TryFindHelperExecutablePath(out string helperPath)) | |||
| { | |||
| var cmdArgs = new StringBuilder("userpass"); | |||
| if (!BitbucketHostProvider.IsBitbucketOrg(targetUri)) | |||
There was a problem hiding this comment.
Can there be a unit test covering this?
Add unit tests for the BitbucketAuthentication command line for UI helpers.
Add test for Bitbucket Cloud hostname detection method.
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the Bitbucket credential UI to show the URL of the Bitbucket Server or Data Center instance, if we're talking to them.
Also fix up the help links to point to a host-relative location; not always to Bitbucket Cloud pages. Note that the OAuth prompt will never been shown for Server/DC since 2FA is not supported there.
This should help resolve some issues raised in #684