Fix Mac x64 pkg #778
Merged
Fix Mac x64 pkg #778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shivanshu3
approved these changes
Jul 6, 2022
jazaval
approved these changes
Jul 6, 2022
baolmtran
approved these changes
Jul 6, 2022
rulicz
approved these changes
Jul 6, 2022
nayanshah
approved these changes
Jul 6, 2022
rodreag
approved these changes
Jul 6, 2022
aaronclarke
approved these changes
Jul 7, 2022
|
Tagging @ldennington , @mjcheetham for review (I don't see an option to assign) |
mjcheetham
approved these changes
Jul 8, 2022
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
smaria3800
reviewed
Oct 15, 2022
| @@ -70,7 +70,7 @@ fi | |||
|
|
|||
| echo "Building for runtime '$RUNTIME'" | |||
|
|
|||
| if [ "$RUNTIME" == "osx-x64"]; then | |||
| if [ "$RUNTIME" == "osx-x64" ]; then | |||
| DISTPATH="$INSTALLER_SRC/distribution.x64.xml" | |||
| else | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
ammr771
reviewed
Nov 20, 2022
This comment was marked as off-topic.
This comment was marked as off-topic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dist.sh script has a typo in it, causing x64 pkgs to include the arm64.xml file instead.
This change fixes the typo, causing the script to produce a validate pkg again for x64 archs on Mac.
Should fix #771