Fix docs/x.md relative links #938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some link references were broken, e.g. `[gcm-wsl]: docs/wsl.md` led to `.../docs/docs/wsl.md` (note 2 `docs` in path) This PR fixes those links to properly point to `.../docs/x.md` (1 `docs` in path)
derrickstolee
approved these changes
Nov 3, 2022
ldennington
requested changes
Nov 3, 2022
There was a problem hiding this comment.
Thanks for catching these! I added some suggestions to align with how we format these links in other docs. It's worth considering on our end using absolute paths to avoid these situations in the future, but until then let's stay consistent with the relative paths.
Comment on lines
+234
to
+235
| [gcm-credstores]: /docs/credstores.md | ||
| [gcm-wsl]: /docs/wsl.md |
There was a problem hiding this comment.
Suggested change
| [gcm-credstores]: /docs/credstores.md | |
| [gcm-wsl]: /docs/wsl.md | |
| [gcm-credstores]: credstores.md | |
| [gcm-wsl]: wsl.md |
| [linux-uninstall]: /docs/linux-fromsrc-uninstall.md |
There was a problem hiding this comment.
Suggested change
| [linux-uninstall]: /docs/linux-fromsrc-uninstall.md | |
| [linux-uninstall]: linux-fromsrc-uninstall.md |
|
We have decided to do a pre-release today, so going to take this as-is and address my feedback separately. |
|
Ok. This happened so fast I only noticed there were requested changes now! I'm glad it was resolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some link references were broken, e.g.
[gcm-wsl]: docs/wsl.mdled to.../docs/docs/wsl.md(note 2docsin path) This PR fixes those links to properly point to.../docs/x.md(1docsin path)