Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

homebrew: update install location for arm64 #966

Closed

Conversation

ldennington
Copy link
Contributor

@ldennington ldennington commented Nov 18, 2022

Homebrew updated the install location for Apple Silicon machines to
/opt/homebrew (instead of /usr/local). Pass runtime information to pack.sh
to determine when this new prefix should be used and update the install
location accordingly.

@ldennington ldennington force-pushed the fix-arm64-homebrew branch 2 times, most recently from a73e1ed to adb102b Compare November 18, 2022 19:46
src/osx/Installer.Mac/pack.sh Outdated Show resolved Hide resolved
@ldennington ldennington marked this pull request as ready for review November 18, 2022 20:48
@ldennington ldennington self-assigned this Nov 18, 2022
Homebrew updated the install location for Apple Silicon machines to
/opt/homebrew (instead of /usr/local). Pass runtime information to pack.sh
to determine when this new prefix should be used and update the install
location accordingly.
Copy link
Contributor

@derrickstolee derrickstolee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working so hard on this. Do you need to wait for @mjcheetham to test this, or are you confident in this change?

@ldennington
Copy link
Contributor Author

@mjcheetham helped me realize that all that's actually needed here is this change. Closing accordingly.

@ldennington ldennington closed this Dec 7, 2022
@ldennington ldennington deleted the fix-arm64-homebrew branch July 12, 2023 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants