Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Git GUI - main window - minor problem with Dark theme #1388

Closed
1 task done
Yousha opened this issue Dec 2, 2017 · 6 comments
Closed
1 task done

Git GUI - main window - minor problem with Dark theme #1388

Yousha opened this issue Dec 2, 2017 · 6 comments

Comments

@Yousha
Copy link

Yousha commented Dec 2, 2017

  • I was not able to find an open or closed issue matching what I'm seeing

Setup

  • Which version of Git for Windows are you using? Is it 32-bit or 64-bit?
    Git 2.15.0 64-bit
$ git --version --build-options

git version 2.15.0.windows.1
built from commit: ed3d106bc93775b62b3860176d7501e079a089b9
sizeof-long: 4
machine: x86_64
  • Which version of Windows are you running? Vista, 7, 8, 10? Is it 32-bit or 64-bit?
    Windows 7 Pro 64-bit
$ cmd.exe /c ver

Microsoft Windows [Version 6.1.7601]
  • What options did you set as part of the installation? Or did you choose the
    defaults?
Path Option: BashOnly
SSH Option: OpenSSH
CURL Option: OpenSSL
CRLF Option: CRLFAlways
Bash Terminal Option: MinTTY
Performance Tweaks FSCache: Enabled
Use Credential Manager: Enabled
Enable Symlinks: Enabled
  • Any other interesting things about your environment that might be related
    to the issue you're seeing?

I'm using Dark Theme for my Windows. <---- IMPORTANT!

Details

  • Which terminal/shell are you running Git from? e.g Bash/CMD/PowerShell/other

None, just Git-GUI

Nothing, it's about Git-GUI colors

  • What did you expect to occur?

Git-GUI (main window) must use Windows native colors for Links, not it's own color(blue)

  • What actually happened instead?

Since I'm using Dark theme for my Windows, I'm not able to see the links on main window in Git-GUI. Check the SS:

  • If the problem was occurring with a specific repository, can you provide the
    URL to that repository to help us with testing?

None.

@PhilipOakley
Copy link

You linked to the same png file twice. Did you mean to link to different files. I can see that the links are awkward to see on the png you referenced.

@Yousha
Copy link
Author

Yousha commented Dec 2, 2017

No, it's fine. They are same
I couldn't find a good section to post them, so I posted them twice

@shiftkey
Copy link

shiftkey commented Dec 4, 2017

Git-GUI (main window) must use Windows native colors for Links, not it's own color(blue)

It's not clear to me what you mean by "native" here. Could you elaborate?

@Yousha
Copy link
Author

Yousha commented Dec 4, 2017

Well, look at this SS: http://s2.zipupload.ir/direct/uid_1_fid3014_1396-09-13_11_57_22_89965547.png
As you can see I changed Hyperlinks color to Light Red(in my Windows Theme), that means ANY standard Hyperlink must be Light Red

So I think you guys Hardcoded those links color to Blue
That's why Windows theme is not able to change/override it
Got it?

@dscho
Copy link
Member

dscho commented Dec 4, 2017

@Yousha please research how to support Dark Theme in Tcl/Tk applications, then open a Pull Request.

Thanks.

@dscho
Copy link
Member

dscho commented Apr 4, 2018

@Yousha the door is always open for Pull Requests.

@dscho dscho closed this as completed Apr 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants