Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[New git-credential-manager version] GCM 2.0.931 #4309

Closed
github-actions bot opened this issue Feb 23, 2023 · 5 comments · Fixed by git-for-windows/build-extra#486
Closed

[New git-credential-manager version] GCM 2.0.931 #4309

github-actions bot opened this issue Feb 23, 2023 · 5 comments · Fixed by git-for-windows/build-extra#486
Assignees
@dscho
Labels
component-update
Milestone
v2.40.0

Comments

@github-actions
Copy link

trace2: remove inaccurate warning and add UI helper exit calls (#1114)

Remove warning about being unable to set up tracing from Trace2
TryParseSettings method. This method should just check to see whether
TRACE2 is enabled - if it is not, it does not need to warn the user, as
we only collect traces from those who actively choose to opt in.

Additionally, GCM's UI helpers are connected to the TRACE2 system via
the Start() call in `ApplicationBase.cs`. Since this call records
`Version` and `Start` events, ensure a corresponding `Exit` event is
called before the helper process completes.

https://github.com/GitCredentialManager/git-credential-manager/releases/tag/v2.0.931
@rimrul
Copy link
Member

rimrul commented Feb 23, 2023 •
edited by gitforwindowshelper bot
Loading

/open pr

The workflow run was started

@dscho
Copy link
Member

dscho commented Feb 23, 2023

Seems that the git-credential-manager name is maybe not liked. I'll have a look.

@dscho
Copy link
Member

dscho commented Feb 23, 2023

Aaargh! I failed to notice that the git-for-windows/gfw-helper-github-app#26 is stalled in review! We need in particular git-for-windows/gfw-helper-github-app@078c977, I would think, to fix this here issue.

@dscho dscho mentioned this issue Feb 23, 2023
Merged
@dscho
Copy link
Member

dscho commented Feb 27, 2023 •
edited by gitforwindowshelper bot
Loading

/open pr

The workflow run was started

@gitforwindowshelper gitforwindowshelper bot mentioned this issue Feb 27, 2023
Merged
@dscho dscho added this to the Next release milestone Feb 27, 2023
@dscho dscho self-assigned this Feb 27, 2023
@dscho
Copy link
Member

dscho commented Feb 27, 2023 •
edited by gitforwindowshelper bot
Loading

/add release note

The workflow run was started

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dscho dscho

Labels
component-update
Projects
None yet
Milestone
v2.40.0
Development

Successfully merging a pull request may close this issue.

mingw-w64-git-credential-manager: update to 2.0.931 git-for-windows/build-extra
2 participants
@dscho @rimrul