Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for i18n ? #18

Open
olberger opened this issue Feb 8, 2021 · 21 comments
Open

Support for i18n ? #18

olberger opened this issue Feb 8, 2021 · 21 comments

Comments

@olberger
Copy link

olberger commented Feb 8, 2021

It looks like the game is merely in english at the moment. Or I've just overlooked how to change language.

At least the git command messages are translated already ;-)

I guess it might be better to have versions in the user's native language, given that it seems to aim beginners.

Would it be feasable to translate it / adapt it (puns and stuff) ?

Thanks in advance.

@blinry
Copy link
Member

blinry commented Feb 9, 2021

This would be great, thanks for the suggestions! Godot itself has good tools for that, we'd need to think about how to translate the level contents itself.

Beause we're still working actively on the content of the game, this is probably not a priority for now.

@olberger
Copy link
Author

I guess this could be very well contributed by others, at least for labels. But having looked at the Godot docs, IIUC there's 2 possible formats, either CSV or gettext. What would be your preference ? I personnaly would prefer gettext, but I imagine you might have other preference.

@faloi
Copy link

faloi commented May 30, 2021

Hi there. I'm interested in translating this to spanish, to use it with my students that don't understand english. I know english is the "universal" language, but in this part of the universe (Argentina) many people don't speak it. 🙃

I can probably involve some colleagues in the translation too.

Any progress on i18n support?

@jballoffet
Copy link

jballoffet commented Jun 4, 2021

I'm also interested in translating this into Spanish, since similarly to @faloi, I'd like to use it with students.

Once i18n support is ready, I could give a hand here performing some of the required translations.

@mcvendrell
Copy link

Another volunteer for Spanish translation. I also translated other opensource projects and I'm used to it.

@olberger
Copy link
Author

Would you mind creating a separate ticket for all matters re spanish translation ? I feel it would be better for all non-spanish speakers/readers.
Muchas gracias ;)

@faloi
Copy link

faloi commented Sep 17, 2021

Hola Federico.

¿Ya lo tenéis listo? Estupendo. No sabría decirte si sería capaz de encontrar todo en neutro. Yo habitualmente lo que hago es traducir los textos a forma más personal (en vez de usted, a tú) e informal. Habría que ver frases concretas para ver si es posible hacerlas neutras y que sigan significando lo mismo. Pero puedo revisarlo, no hay problema. ¿Dónde está la traducción?

Un saludo.
Manuel.

I've mistaken this project with another one I'm contributing, sorry. I already deleted my comment, but I imagine you read it on your email.

Regarding this translation, the main issue is the project doesn't have support for i18n. So, to start translating, that support needs to be added.

@schokotets
Copy link

Hello @jballoffet @mcvendrell - I'm glad you're offering to translate the game into Spanish. It would help out lots of people!

As far as I can tell (as a newbie to the project), there is a pull request whose code adds a translation mechanism: #129
If you feel up to it, I'd suggest having a look at it and starting your own pull request diverging from it, and get started translating. I assume, once internationalization is a supported feature, that the format will be similar enough to the one in the pull request. That means you could start working at it right away without the risk of "doing it all for nothing".

If you need any technical help, feel free to reach out to me! While I'm fairly unfamiliar with the game's source code, I know git / GitHub processes and can assist you with them.

Thanks again for offering your support!

@mcvendrell
Copy link

Thanks @schokotets (and @m0rp30 for the effort), but the proposed system is very messy: you have to navigate to a lot of different files in different folders, and edit texts in different locations of that files.
I think there must be a better way to do this translation effort, putting all the texts in a common file, like we all are used to working with.

@m0rp30
Copy link

m0rp30 commented Mar 25, 2022

@mcvendrell I realize that there are many files to be modified and the system I proposed is structured in this way because I did not want to change the way the game was developed, however in 6 months I could also fix this type problem but I have never been told anything about the problem of many files to modify, now I can see if a better way can be found for the translation logic.

@mcvendrell
Copy link

Thank you @m0rp30, will wait till then.

@sirbaconjr
Copy link

@m0rp30, are you still working on this? Just learned about this game and I would love to see some other languages in it (like pt_BR) and I would like to help.

@oliveirafilipe
Copy link

Hi Guys, any updates?
I'm also a volunteer for a PT-BR translation.

@martinvilu
Copy link

Hello, ¿may I suggest using an external tool like POEditor?
I'm also a Spanish-speaking teacher, looking forward to the translation of this fantastic game. And I can help with the translation too.

@schokotets
Copy link

schokotets commented Aug 15, 2022

I would like to push on i18n efforts because I believe in the value the game provides, because it seems like nothing much has changed since #129 and the proposed changes.

@blinry and I have talked: we propose some changes to the implementation of i18n in the pull request #129 . The pull request's thread is where technical discussion can take place.

Thank you to @mcvendrell @sirbaconjr @oliveirafilipe @martinvilu for offering to aid in translation. If you're eager to contribute soon, you can start translation via fork / pull-request by copying the level structure as done in #129 or even modifying it in-place. It might be a good idea to create an issue per locale so a locale's translators can have a space to collaborate. Please don't forget to link back to this issue.

While it's possible that a mirror of the level tree will not be the final data structure for translation, I believe that your contributions could be transformed into a possible new shape with feasible efforts. Of course, you're free to wait until technical questions are cleared.

@scarf005
Copy link

this looks promising! also interested in translating it to korean.

@m0rp30 m0rp30 mentioned this issue Aug 19, 2022
@m0rp30
Copy link

m0rp30 commented Aug 19, 2022

i have close the pull request # 129 and make new one # 146 with a new mechanism of internationalization, for my it's a really good work now !!!

@User670
Copy link

User670 commented Dec 20, 2023

Random thought. Git supports languages too, and probably also the git bash console. Will localized version of the game use English git, or can the git too be configured to use another language?

(screenshot is my own installation of git, configured to use Chinese. Git for Windows doesn't come with Chinese tho, and I had to manually put the Chinese language files in there: git-for-windows/git#4368 , not sure how language works in other versions of git.)

image

@m0rp30
Copy link

m0rp30 commented Dec 20, 2023

(screenshot is my own installation of git, configured to use Chinese. Git for Windows doesn't come with Chinese tho, and I had to manually put the Chinese language files in there: git-for-windows/git#4368 , not sure how language works in other versions of git.)

I didn't know this feature of GIT, for the moment the localized version of the game uses GIT in the English version, but it could be an interesting feature to implement.

However, my request has not yet been inserted into the main branch

@attilastrba
Copy link

Greate work... is there any german localisation for this game? Or did anyone already translate the files to german and could point me to the repo? Thanks

@m0rp30
Copy link

m0rp30 commented Apr 10, 2024

Greate work... is there any german localisation for this game? Or did anyone already translate the files to german and could point me to the repo? Thanks

My pull request #152 has not been accepted yet ( from 3 years ago ), I don't know if there is a German translation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests