the walking dead (pt 3)

[technoweenie]

Building on #1008 (/cc @rlaakkol). Just moved the Wait() call before closing the channels, as described in #1008 (comment).

[technoweenie]

/cc @rubyist, @sinbad: would love some 👀 here if you have any time.

[technoweenie]

FWIW, I audited the app's other uses of the os/exec package. Looks like we're calling Wait() everywhere else. I'm not sure what that extra defunct git process is from. I added trace messages around startCommand() in lfs/scanner.go (diff) and saw every command it started was finishing properly:

$ git push ghe --all
CMD START /Library/Developer/CommandLineTools/usr/libexec/git-core/git [git rev-list --objects 16f09066000e3328fb2d5c54beb55fc25c1af15c --not --remotes=ghe]
CMD START /Library/Developer/CommandLineTools/usr/libexec/git-core/git [git cat-file --batch-check]
CMD START /Library/Developer/CommandLineTools/usr/libexec/git-core/git [git cat-file --batch]
CMD STOP /Library/Developer/CommandLineTools/usr/libexec/git-core/git [git rev-list --objects 16f09066000e3328fb2d5c54beb55fc25c1af15c --not --remotes=ghe]
CMD STOP /Library/Developer/CommandLineTools/usr/libexec/git-core/git [git cat-file --batch-check]
CMD STOP /Library/Developer/CommandLineTools/usr/libexec/git-core/git [git cat-file --batch]

[rubyist]

The waits look right to me 👍

[sinbad]

Yeah, looks good - I bet Windows was especially susceptible to this, I've had issues before of git leaving files locked sometimes because of things like this. Nice one.

[technoweenie]

Thanks for the reviews!