Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User agent #114

Merged
merged 3 commits into from
Sep 9, 2014
Merged

User agent #114

merged 3 commits into from
Sep 9, 2014

Conversation

technoweenie
Copy link
Contributor

This sets a User-Agent on outgoing Git Media API requests. It also expands the version command so it shows the Git and Go versions:

$ script/run version
git media v0.2.1 (go v1.3)
git version 1.9.1

@rubyist
Copy link
Contributor

rubyist commented Sep 9, 2014

💥 :shipit:

technoweenie added a commit that referenced this pull request Sep 9, 2014
@technoweenie technoweenie merged commit 63ba097 into master Sep 9, 2014
@technoweenie technoweenie deleted the user-agent branch September 9, 2014 17:24
@shiftkey
Copy link
Contributor

shiftkey commented Sep 9, 2014

Are you interested in which OS is sending the request?

@technoweenie
Copy link
Contributor Author

@shiftkey: Why, yes I am! I'll get that in the next release.

@rubyist: We should try parsing this and sending it as separate params to the media logger.

@rubyist
Copy link
Contributor

rubyist commented Sep 10, 2014

Do we have any existing code anywhere that parses the OS out of the user agent string? Doesn't have to be in Go, just something to look at so we can keep things consistent and not reinvent wheels and such.

@jspahrsummers
Copy link

@rubyist Check out @josh's useragent gem.

@technoweenie
Copy link
Contributor Author

Oh wow, I had no idea: http://www.texsoft.it/index.php?m=sw.php.useragent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants