lfs/hook: teach lfs.Hook about core.hooksPath
#1409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit gives the `lfs.Hook` knowledge of the new `core.hooksPath` configuration value that was introduce in Git 2.9.0. When `core.HooksPath` is found in the Git configuration AND is supported (i.e., installed Git binary has a version greater than or equal to "2.9.0"), `git-lfs install` will place new hooks in that directory. If the `core.hooksPath` is specified, but the installed verison of Git does NOT support it, then it will be ignored and installed in `.git/hooks` as per usual. To test this behavior, two new shell tests were added: - One that runs on Git >= 2.9.0, and tests that `core.hooksPath` is respected - One that runs on Git < 2.9.0, and tests that `core.hooksPath` is ignored Unfortunately, our current testing framework does not support skipping individual tests, only skipping entire files, so two new shell test files were added. Resolves #1407.
| git lfs install 2>&1 | tee install.log | ||
| grep "Updated pre-push hook" install.log | ||
|
|
||
| [ -e "$hooks_dir/pre-push" ] |
There was a problem hiding this comment.
Should this have [ ! -e ".git/hooks/pre-push" ] too? Also, both tests misspell "perform" :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit gives the
lfs.Hookknowledge of the newcore.hooksPathconfiguration value that was introduce in Git 2.9.0.
When
core.HooksPathis found in the Git configuration AND is supported (i.e.,installed Git binary has a version greater than or equal to "2.9.0"),
git-lfs installwill place new hooks in that directory. If thecore.hooksPathisspecified, but the installed verison of Git does NOT support it, then it will
be ignored and installed in
.git/hooksas per usual.To test this behavior, two new shell tests were added:
core.hooksPathis respectedcore.hooksPathis ignoredUnfortunately, our current testing framework does not support skipping
individual tests, only skipping entire files, so two new shell test files were
added.
Resolves #1407.
/cc @technoweenie