distinguish between empty include/exclude paths #1411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reduces the chance of bugs between the flag handling in pull/fetch/clone
| if fetchAllArg { | ||
| if fetchRecentArg || len(args) > 1 { | ||
| Exit("Cannot combine --all with ref arguments or --recent") | ||
| } | ||
| if fetchIncludeArg != "" || fetchExcludeArg != "" { | ||
| if include != nil || exclude != nil { |
There was a problem hiding this comment.
@ttaylorr This is why I need to call getIncludeExcludeArgs() separately.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses a
pflag.Flag'sChangedproperty to determine if the--includeor--excludeflags are empty or omitted. I'm not convinced using*stringis any better than setting the default flag value to some magic string likeOPTIONAL. It does remove any possibility of clashing with a directory in a user's repository, I suppose.I also ran into some failures in large
test-fetch.shtests that rungit lfs fetchmultiple times. Those instances were really difficult to debug, so I split a couple of them up into separate files.Fixes #1249