add support for url.*.insteadof in git config #1443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if longestalias < alias { | ||
| longestalias = alias | ||
| } else if longestalias == alias { | ||
| fmt.Fprintf(os.Stderr, "WARNING: Multiple 'url.*.insteadof' keys with the same alias: %q", alias) |
There was a problem hiding this comment.
Should we have an integration test for this?
There was a problem hiding this comment.
Why yes, we should, because it caught a bug :)
|
Looks good, let's 🚢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrite of #1117 after the config refactoring in #1425. There's no
readGitInsteadOfConfig()anymore to hook into anymore.We can't easily support
pushinsteadofwithout bigger changes.config.NewEndpointWithConfig()doesn't know if the request is a push or pull.