Fetch remote urls #1451
Merged
Fetch remote urls #1451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -37,12 +37,17 @@ func NewEndpointFromCloneURLWithConfig(url string, c *Configuration) Endpoint { | |||
| return e | |||
| } | |||
|
|
|||
| if strings.HasSuffix(url, "/") { | |||
There was a problem hiding this comment.
Since we already have path imported, would it be possible to use path.Clean here?
There was a problem hiding this comment.
We could, but it does a lot more stuff besides just chomping the trailing / that we don't need. These urls either come from the git remote config (remote.origin.url), or from custom lfs config (lfs.url, remote.origin.lfsurl).
|
|
||
| # LFS object not downloaded, pointer in working directory | ||
| refute_local_object "$contents_oid" | ||
| ack "$content_oid" a.dat |
There was a problem hiding this comment.
I don't think the containers that Travis gives us have ack installed.
|
After you switch out |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for pushing and pulling LFS objects with a raw remote url. This was originally submitting in #1085, and updated for the current master branch. This also adds tests.