check the git version is ok in some key commands #1461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -334,6 +334,18 @@ func isCommandEnabled(cfg *config.Configuration, cmd string) bool { | |||
| return cfg.Os.Bool(fmt.Sprintf("GITLFS%sENABLED", strings.ToUpper(cmd)), false) | |||
| } | |||
|
|
|||
| func requireGitVersion() { | |||
| minimumGit := "1.8.2" | |||
There was a problem hiding this comment.
I wonder if it would be worth elevating this to a method argument, and having a const in the commands package.
This would allow us to easily require different versions of Git for different commands, but I'm not sure that's behavior we need.
There was a problem hiding this comment.
This is the absolute minimum requirement for Git LFS to run safely. We can add a const if something else needs this specific value, but nothing does right now. Other bits in the codebase that check the git version already use IsGitVersionAtLeast():
$ ack IsGitVersionAtLeast
commands/command_clone.go
89: if !git.Config.IsGitVersionAtLeast("2.9.0") {
git/git.go
406:func (c *gitConfig) IsGitVersionAtLeast(ver string) bool {
790: if !Config.IsGitVersionAtLeast("2.8.0") {
git/git_test.go
205: if !Config.IsGitVersionAtLeast("2.5.0") {
lfs/hook.go
41: customHooksSupported := git.Config.IsGitVersionAtLeast("2.9.0")There was a problem hiding this comment.
Ah, this makes sense as an absolute min.
|
Aside from my one comment, 👍 |
|
🚢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc #1212