Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically upgrade old filters instead of requiring —force #1497

Merged
merged 1 commit into from Sep 1, 2016

Conversation

sinbad
Copy link
Contributor

@sinbad sinbad commented Sep 1, 2016

Came across a case recently where someone hadn't used git-lfs for a while and suddenly got errors on git lfs install of the form:

filter.lfs.clean attribute should be "git-lfs clean --%f" but is "git-lfs clean %f"

This surprised me because I thought we had upgrade paths for our config, but turns out that was only for hooks. So rather than making them run git lfs install --force for something we already know about, I introduced the same concept as for hooks, a list of upgradeable values we used to use.

While I was at this I removed the attribute upgrade path for git-media, since it was vague and over-general really and I don't think it's necessary any more? I can put it back if there was a specific reason it's still there but looked like a relic to me.

Also remove upgrade path for `git-media` since over-general and should
not be needed any more
@sinbad sinbad added the review label Sep 1, 2016
@technoweenie
Copy link
Contributor

Awesome, thanks for adding this!

The git-media stuff is way outdated. I don't think there's any need to find every filter we used during development :)

@technoweenie technoweenie merged commit 5edb8a7 into master Sep 1, 2016
@technoweenie technoweenie deleted the upgrade-old-filters branch September 1, 2016 16:25
@ttaylorr
Copy link
Contributor

ttaylorr commented Sep 1, 2016

This looks awesome. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants