Make AppVeyor CI for Windows work again #1506
Conversation
All the src contains is a symbolic link to the root, causing gofmt to
indefinitely recurse until it errors out. On Windows, this causes an error
message like
GetFileAttributesEx
src\github.com\github\git-lfs\src\github.com\github\git-lfs\src\github.com\github\git-lfs\src\github.com\github\git-lfs\src\github.com\github\git-lfs\.git\objects\pack\pack-2fc21819ce9855ebf1a1f3ac77cf464c8a4e6e42.idx:
The system cannot find the path specified.
| # that we need. | ||
| if [ -z "$GOPATH" ] && uname -s | grep -vq "_NT-"; then | ||
| # Tell MSYS to really create symbolic links. | ||
| export MSYS=winsymlinks:nativestrict |
There was a problem hiding this comment.
Are you able to do this from within the appveyor.yml?
There was a problem hiding this comment.
I guess so, but then calling script/bootstrap on a local Windows developer machine (from Git Bash) would not properly work unless that variable is already set.
There was a problem hiding this comment.
If you feel better about it, I can limit setting that variable to Windows...
There was a problem hiding this comment.
Ah, good idea. If we're in a Windows environment while running script/bootstrap, then we can set $MSYS.
There was a problem hiding this comment.
Right. I'll simply re-use parts of the existing check for that.
|
This is looking good. I left a few minor comments, mostly me asking questions about how AppVeyor works 😅 . One thing to note is that this won't generate signed releases of Git LFS that we can upload as our official Windows installer. I don't think this is a problem for now, since getting some sort of test harness in place for verifying that the Windows installer builds correctly is definitely a step forward. I'd love to look into how we could get AppVeyor to sign our releases for us in the future, since that's definitely something that we'd like to do. |
The Inno Setup compiler |
|
I've pushed another version that only exports the MSYS (and now also CYGWIN) variable on Windows. |
|
Thanks for being so quick to respond to my comments! I'm going to wait for the tests to pass and then merge this to master and test it out. |
|
Please do not merge yet, there's a small bug I'll fix from home in an hour or so! |
AppVeyor now has Go and Git for Windows 2.x installed by default. Also, we can tell MSYS to actually create symbolic links. Finally, let the CI create the installer, too.
|
Fixed, see the AppVeyor artifacts at https://ci.appveyor.com/project/sschuberth/git-lfs/build/1.0.19/artifacts |
|
Interesting, why's this at git-lfs/git-lfs and not at https://ci.appveyor.com/project/github/git-lfs/build/artifacts? |
|
We're planning to move to https://github.com/git-lfs soon anyway. |
|
Also, looking at #1505 it seems two AppVeyor builds get kicked off, continuous-integration/appveyor/branch and continuous-integration/appveyor/pr. Is this intended? |
|
Good catch. I enabled the "Do not build feature branches with open Pull Requests" option. |
This build the binaries and installer for now. Not running tests yet.