use filepath.Clean() when comparing filenames to include/exclude patterns

[technoweenie]

This removes the windows-specific hacks, and uses filepath.Clean() to sanitize the paths. This broke previously because it was filepath.Match() expects back slashes on windows.

[technoweenie]

/cc @ttaylorr @sinbad @sschuberth This is the last thing I need for script/integration to pass on my windows machine.

[ttaylorr]

This looks good. There's some duplication here, but this function has a good amount of it already. 👍

[sschuberth]

@technoweenie Thanks for this. Out of curiosity, are you running on Windows 10? Because on Windows 10 I see more test failures than on Windows 8.1. These additional failures seem to be related to Windows short vs. long path issues where Windows 10 seems to behave differently, and I'm trying to address them as part of my windows-tests branch.

[sinbad]

👍 Looks like the main issue here was people using '' separators in their include/exclude config, which I don't usually advocate (all other git settings tend to work better using '/' even on Windows), but this is good belt & braces. The tests didn't used to fail on Windows for that, maybe something else has been changed in the meantime.

[technoweenie]

Out of curiosity, are you running on Windows 10? Because on Windows 10 I see more test failures than on Windows 8.1.

I ran them on my Windows 10 gaming pc :)