Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .mailmap #1593

Merged
merged 1 commit into from Oct 18, 2016
Merged

Update .mailmap #1593

merged 1 commit into from Oct 18, 2016

Conversation

dpursehouse
Copy link
Contributor

Change-Id: I139809347d7e59d85758e3696a01f2e2e8329c91
Signed-off-by: David Pursehouse dpursehouse@collab.net

Change-Id: I139809347d7e59d85758e3696a01f2e2e8329c91
Signed-off-by: David Pursehouse <dpursehouse@collab.net>
@sschuberth
Copy link
Member

Note sure what the policy is here, but I find it confusing to have Gerrit's Change-Id in the commit message body (BTW, it's a pity that GitHub still doesn't let me add review comments to lines of commit messages). Similarly for the Sign-off-by, this project does not require it, but is it ok to leave it in?

@dpursehouse
Copy link
Contributor Author

@sschuberth I have the Gerrit hook installed in my templates so it gets added on all new clones. I could manually remove it, but meh. If project owners don't like it they remove it (see commits on facebook/buck for example) and I'm fine with that.

@sschuberth
Copy link
Member

@dpursehouse I just checked, given that your previous commits with both Change-Id and Sign-off-by were accepted, I guess this is fine, too :-)

@sschuberth sschuberth merged commit da7533c into git-lfs:master Oct 18, 2016
@dpursehouse dpursehouse deleted the update-mailmap branch October 18, 2016 08:03
Rick Olson <technoweenie@gmail.com> rick <technoweenie@gmail.com>
Rick Olson <technoweenie@gmail.com> risk danger olson <technoweenie@gmail.com>
Rick Olson <technoweenie@gmail.com> Your Name <you@example.com>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this supposed to map to Your Name <you@example.com>?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, from Your Name <you@example.com> to Rick Olson <technoweenie@gmail.com>. I remember also stumbling upon a commit from this user when I created my .mailmap, but I did not find sufficient proof that this is in fact @technoweenie. I guess @dpursehouse still remembered that this is the case.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 . Cool, thanks for clarifying!

@dpursehouse
Copy link
Contributor Author

No 100% absolute concrete evidence, but the commit with this name seems to
be from Rick.

On Wed, 19 Oct 2016 00:20 Taylor Blau, notifications@github.com wrote:

@ttaylorr commented on this pull request.

In .mailmap #1593:

Rick Olson technoweenie@gmail.com rick technoweenie@gmail.com
Rick Olson technoweenie@gmail.com risk danger olson technoweenie@gmail.com
+Rick Olson technoweenie@gmail.com Your Name you@example.com

👍 . Cool, thanks for clarifying!


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#1593, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAzDSg8FF5orMe8UJoV3g-Q_0ans6fsFks5q1OPOgaJpZM4KZXcy
.

@ttaylorr ttaylorr added the 1.4.4 label Oct 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants