Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

re-enable push and pre-push dry-run flags #1673

Closed
wants to merge 1 commit into from
Closed

re-enable push and pre-push dry-run flags #1673

wants to merge 1 commit into from

Conversation

technoweenie
Copy link
Contributor

My push/pre-push refactoring (#1128) inadvertently broke dry runs of these commands.

ttaylorr
ttaylorr reviewed Nov 17, 2016
View reviewed changes
Copy link
Contributor

@ttaylorr ttaylorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Wondering if we should do a refute_server_object in some of the integration tests like this one?

@technoweenie technoweenie mentioned this pull request Nov 17, 2016
Closed
@technoweenie
Copy link
Contributor Author

Doh, setting DryRun in

git-lfs/commands/uploader.go

Lines 18 to 20 in ced5270

func newUploadContext(dryRun bool) *uploadContext {
return &uploadContext{
DryRun: dryRun,
. False alarm, people.

@technoweenie technoweenie deleted the push-dry-run branch November 17, 2016 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttaylorr ttaylorr ttaylorr left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@technoweenie @ttaylorr