lfs,cmd: remove lfs.New{Downloadable,Uploadable} #1776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tracking: #1764. |
|
|
||
| // ensureFile makes sure that the cleanPath exists before pushing it. If it | ||
| // does not exist, it attempts to clean it by reading the file at smudgePath. | ||
| func ensureFile(smudgePath, cleanPath string) error { |
There was a problem hiding this comment.
I think we can just get rid of ensureFile() in this test command. It's generating the data on the fly, so I'm not sure how it'd ever get into a weird state.
There was a problem hiding this comment.
Great call! Got it in: d8fc641. Once that passes, I'll merge this PR into master.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull-request moves the
lfs.NewDownloadableandlfs.NewUploadablefunctions into thecommandspackage and un-exports them.As an aside, the
NewUploadablealternative had to be copied into thetestpackage, since it was inaccessible as a private member of thecommandspackage. I think this follows the Go-ism: "A little copy is better than a little dependency."/cc @git-lfs/core