ci: run builds on 'next' branch of git.git #2470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larsxschneider
requested changes
Aug 2, 2017
circle.yml
Outdated
| @@ -4,6 +4,7 @@ machine: | |||
| GIT_SOURCE_REPO: https://github.com/git/git.git | |||
| GIT_EARLIEST_SUPPORTED_VERSION: v2.0.0 | |||
| GIT_LATEST_SOURCE_BRANCH: master | |||
| GIT_NEXT_SOURCE_BRANCH: master | |||
There was a problem hiding this comment.
@larsxschneider great catch! I fixed that up in: a2e6e2d.
| @@ -12,6 +12,7 @@ env: | |||
| - GIT_SOURCE_REPO="https://github.com/git/git.git" | |||
| - GIT_EARLIEST_SUPPORTED_VERSION="v2.0.0 | |||
| - GIT_LATEST_SOURCE_BRANCH="master" | |||
| - GIT_NEXT_SOURCE_BRANCH="next" | |||
There was a problem hiding this comment.
You could also defined GIT_LATEST_SOURCE_BRANCH="next" for the time being.
That's why I called it LATEST and not MASTER back then 😄
There was a problem hiding this comment.
I think running on master & next for the time being will be fine.
| @@ -4,6 +4,7 @@ machine: | |||
| GIT_SOURCE_REPO: https://github.com/git/git.git | |||
| GIT_EARLIEST_SUPPORTED_VERSION: v2.0.0 | |||
| GIT_LATEST_SOURCE_BRANCH: master | |||
| GIT_NEXT_SOURCE_BRANCH: next | |||
There was a problem hiding this comment.
Is this the same line as #2470 (comment)?
rubyist
approved these changes
Aug 2, 2017
larsxschneider
approved these changes
Aug 2, 2017
ttaylorr
force-pushed
the
ci-run-on-next
branch
from
33cf98c
to
a2e6e2d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request teaches CircleCI and Travis how to run CI with the version of Git present at the tip of branch 'next'.
This is useful for adding the 'delay' capability to
git lfs filter-process(see: #2466), since the 'delay' capability is not yet in master, or a released version of Git. This will give us a chance to test the 'delay' functionality out in CI before it's released in Git.Once Git releases a version that contains git/git@2841e8f, we can revert this pull request.
This is required work for: #2466.
/cc @git-lfs/core
/cc #2466