lfsapi: prefer proxying from gitconfig before environment #3062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ttaylorr
changed the title
ttaylorr
force-pushed
the
lfsapi-env-before-gitconfig
branch
from
fef3d76
to
5db9370
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request changes the behavior of package
lfsapito prefer the HTTP(s) proxy values originating from the environment, rather than the Git configuration.As noted in #3060, this was originally the case when it was introduced in #1358, but was changed in #1787.
From the Git documentation [1]:
This is technically a breaking change, but it's one that I would feel comfortable releasing along the v2.5.0 line, since holding back such a small patch until v3.0.0 feels unwise.
Closes: #3060.
/cc @git-lfs/core @larsxschneider
/cc #3060 @kenyon