subprocess: don't treat empty PATH component as . on Windows #4603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bk2204
force-pushed
the
windows-no-empty-path
branch
from
d459bdb
to
8fa68f6
Compare
It's common for Windows machines to have trailing empty PATH components and users there don't expect that to mean "." like it does on Unix. To avoid unexpected behavior and somewhat improve security, treat the empty PATH component differently on Windows.
bk2204
force-pushed
the
windows-no-empty-path
branch
from
8fa68f6
to
7cd7bb0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's common for Windows machines to have trailing empty PATH components and users there don't expect that to mean "." like it does on Unix. To avoid unexpected behavior and somewhat improve security, treat the empty PATH component differently on Windows.