migrate: properly escape blob filenames #4683
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please consider this minor PR to fix the below bug. I added a unit test. I hope this is straightforward.
Describe the bug
When files have a combination of spaces and parentheses/dashes, git lfs migrate import produces invalid filenames in .gitattributes
To Reproduce
Steps to reproduce the behavior:
Expected behavior
.gitattributes should escape the filenames. Ideally they should be in double quotes (c-style escaping), but pattern escaping also should be OK.
System environment
Debian 10.10 and git lfs 3.0.1
Output of
git lfs env
The output of running
git lfs env
as a code block.