Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git: honor GIT_OBJECT_DIRECTORY #4686

Merged
merged 1 commit into from Oct 18, 2021
Merged

git: honor GIT_OBJECT_DIRECTORY #4686

merged 1 commit into from Oct 18, 2021

Conversation

bk2204
Copy link
Member

@bk2204 bk2204 commented Oct 14, 2021

When we're in certain server-side hooks, the GIT_OBJECT_DIRECTORY environment variable is set so we can read and write temporary objects which are quarantined there. However, Git LFS doesn't currently honor that environment variable. Let's make it do so, so that we can invoke Git LFS in the normal way in such an environment.

Fixes #4685

@bk2204 bk2204 force-pushed the object-dir-env branch 2 times, most recently from f82ffe7 to de1cfee Compare October 15, 2021 16:13
@bk2204 bk2204 marked this pull request as ready for review October 18, 2021 12:22
@bk2204 bk2204 requested a review from a team October 18, 2021 12:22
Copy link
Contributor

@chrisd8088 chrisd8088 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor question aside, looks great, thank you.

t/t-fsck.sh Outdated Show resolved Hide resolved
When we're in certain server-side hooks, the GIT_OBJECT_DIRECTORY
environment variable is set so we can read and write temporary objects
which are quarantined there.  However, Git LFS doesn't currently honor
that environment variable.  Let's make it do so, so that we can invoke
Git LFS in the normal way in such an environment.
@bk2204 bk2204 merged commit a64437a into git-lfs:main Oct 18, 2021
@bk2204 bk2204 deleted the object-dir-env branch October 18, 2021 17:13
bk2204 added a commit to bk2204/git-lfs that referenced this pull request Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

git lfs fsck --pointers doesn't respect GIT_OBJECT_DIRECTORY
2 participants