New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update INSTALLING.md to fix ubuntu derivative command and allow easy install for some distros #5014
Conversation
- Fix for duplicate `sudo` which causes it to not correctly pass environment variables - Comment for Pop OS and automatic dist selection for Ubuntu based distributions
Update to use `env` command and wrap to prevent shell env pollution
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great. Thanks so much for the patch and for the quick turnaround time in getting this in shape. Since I'll be cutting a release today, we can include this as part of it.
It looks like we have some trailing whitespace here that's causing CI to fail. Could you fix that? |
Remove single space after pipe character
@bk2204 Should be fixed now! Single space after the pipe character. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this looks good. I'll merge it after we've done our release on Wednesday.
|
This still looks good to me, so I'm going to merge it once the CI jobs are complete. |
sudo
which causes it to not correctly pass environment variablesIt would be cool if packagecloud could support more distros considering Mint and Pop OS are fairly popular, but that isn't a problem for git-lfs.