Apply several Makefile fixes for Windows #5016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Windows, the tar shipped with the OS is a BSD (libarchive) tar. However, under Git for Windows, the tar command is a GNU tar, which is also the case in GitHub Actions. As a result, we need to explicitly specify the path for bsdtar in a different way than for Unix systems, where we can just typically fall back to "bsdtar", so let's specify the full path.
The bsdtar on Windows is not compiled with the -s option, so perform the same operations, just by hand.
GitHub Actions no longer has signtool in the location it did previously. Let's specify an appropriate PATH value so that we can sign binaries.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upon testing our release process, I noticed that there were a few bugs on Windows. Items fixed include:
signtool.exe;bsdtar -son Windows, since that doesn't work.Each commit has its own commit message explaining the rationale.