Change git-lfs migrate import --everything to migrate everything except for special git refs #5045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pt for special git refs.
bk2204
reviewed
Jun 13, 2022
| } | ||
| prefix := strings.Join(parts[:2], "/") | ||
| switch prefix { | ||
| case "refs/notes", "refs/bisect", "refs/replace": |
There was a problem hiding this comment.
I think we'll also want to include refs/stash here, since we won't want to rewrite stashes.
There was a problem hiding this comment.
Added a small unit test, I'll probably need a bit more time to figure out the how to get the test right in .sh unless people want to give some help on generating examples of excluded refs.
There was a problem hiding this comment.
I think this is probably fine as it stands.
bk2204
approved these changes
Jun 15, 2022
| } | ||
| prefix := strings.Join(parts[:2], "/") | ||
| switch prefix { | ||
| case "refs/notes", "refs/bisect", "refs/replace": |
There was a problem hiding this comment.
I think this is probably fine as it stands.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements @bk2204 's suggestion in #4810 to only exclude special git refs.