Update stale comments relating to object scanning and uploading #5163
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates several stale comments that relate to scanning Git blob objects to find valid Git LFS pointers and to validating that objects have corresponding local file copies before uploading them.
In commit e3fcde7 of PR #3236 the
ObjectScanner
type was updated to use an internalObjectDatabase
from thegithub.com/git-lfs/gitobj
package rather than invoking an externalgit cat-file --batch
command. However, the comments for thecatFileBatch()
andrunCatFileBatch()
functions were not updated at the same time and still state that they cause agit cat-file --batch
command to run, so we update them now.And in commit 338ab40 of PR #1812 the
prepareUpload()
function was refactored so that it no longer checked whether an object to be pushed had a local file copy or not and skipped it if it did not. However, the comment which stated that the function skipped any objects which did not have local file copies was not updated, so we now revise that comment and add one in theuploadTransfer()
function.