Unset GIT_TRACE
environment variable for Git commands in Makefile
#5240
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In commit c4874df of PR #971 the
script/cibuild
script was revised to run the Go test suite just for ourgit
Go package in order to confirm that we do not leak theGIT_TRACE
environment variable to Git itself when it is set.Later, in commit 2235198 of PR #3144, our
Makefile
was updated to start by running some Git commands (git describe
andgit rev-parse
) to determine the current tagged version of the project.When
GIT_TRACE=1
is set in second run of the Go test suite, these initial Git command output Git trace log lines, which does not affect the validity of the second Go test of ourgit
package but does add some noise to the output of thescript/cibuild
script, for example:We therefore just unset the
GIT_TRACE
environment variable for these two Git commands in ourMakefile
.