Build release assets with Go 1.21 #5668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to the issue noted in golang/go#65705, we don't want to build our release assets with 1.22.0, since this can cause deadlock in the HTTP client. Instead, let's keep testing with both 1.21 and 1.22 in our CI jobs, but build with 1.21 for release. In the future, once that bug is fixed and an updated version is released, we can move back to 1.22.
chrisd8088
approved these changes
Mar 4, 2024
bk2204
added a commit
that referenced
this pull request
Mar 6, 2024
Build release assets with Go 1.21
hswong3i
pushed a commit
to alvistack/git-lfs-git-lfs
that referenced
this pull request
Mar 8, 2024
Build release assets with Go 1.21
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the issue noted in golang/go#65705, we don't want to build our release assets with 1.22.0, since this can cause deadlock in the HTTP client. Instead, let's keep testing with both 1.21 and 1.22 in our CI jobs, but build with 1.21 for release.
In the future, once that bug is fixed and an updated version is released, we can move back to 1.22.