Fix fallthrough when git-lfs-authenticate returns an error #909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If using an SSH URL and git-lfs-authenticate returns an error, without this change the error is just reported to the trace but execution continues. A common result is a completely made up LFS URL being returned which then 404's, which ends up setting lfs.batch=false. If the server doesn't implement the non-batch interface, this config then breaks LFS even after the SSH issue is resolved & has to be manually removed.
technoweenie
added a commit
that referenced
this pull request
Dec 24, 2015
Fix fallthrough when git-lfs-authenticate returns an error
|
Yuck :( Thanks for the fix :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If using an SSH URL and git-lfs-authenticate returns an error, without this change the error is just reported to the trace but execution continues.
A common result is a completely made up LFS URL being returned which then 404's, which ends up setting lfs.batch=false. If the server doesn't implement the non-batch interface, this config then breaks LFS even after the SSH issue is resolved & has to be manually removed, which is quite confusing for the user.