Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

guard against invalid remotes passed to git lfs push #974

Merged
merged 2 commits into from Feb 4, 2016

Conversation

technoweenie
Copy link
Contributor

Fixes #973

@sgoo
Copy link

sgoo commented Feb 3, 2016

Should this also be applied to pre-push?
If I do:

$ GIT_TACE=1 git push http://sgoo@git-server.com/sgoo/test.git
...
12:47:18.836067 git.c:561               trace: exec: 'git-lfs' 'pre-push' 'http://sgoo@git-server.com/sgoo/test.git' 'http://sgoo@git-server.com/sgoo/test.git'
...

You can see pre-push is invoked with the URL I provided to git push. But the request that is made in pre-push is made to the remote configured as origin.

@technoweenie
Copy link
Contributor Author

deleted

@technoweenie
Copy link
Contributor Author

WOW, I thought you were replying to #971 for some reason. Ignore everything I said in my last reply. I'll take a look at pre-push.

technoweenie added a commit that referenced this pull request Feb 4, 2016
guard against invalid remotes passed to `git lfs push`
@technoweenie technoweenie merged commit 4857922 into master Feb 4, 2016
@technoweenie technoweenie deleted the push-with-invalid-remote branch February 4, 2016 15:44
@technoweenie
Copy link
Contributor Author

Thanks for the feedback! I added it to pre-push as you suggested.

@technoweenie technoweenie mentioned this pull request Feb 4, 2016
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants