wildmatch: ensure given patterns are POSIX-compliant #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces
slashEscape, which ensures that given paths are (pseudo) POSIX-compliant, while preserving the meaningfulness of escape sequences.Wildmatch expects to perform pattern matching operations on POSIX-compliant paths (and mingw converts automatically [1]), but it is possible that the Windows command prompt does not do this.
To ensure correctness, convert to POSIX ourselves.
This pull request also removes three test cases that have behavior defined by the platform on which they are run. For instance, consider the test
\a\b\c, which indicatesa/b/c(in POSIX) on Windows, but on macOS is three invalid escape sequences. The behavior for these cases should be left undefined.