Merge pull request #280 from pmiossec/remove_git_call_for_set_config

Remove call to git command to set config (use libgit2sharp instead)
git-tfs · Jan 7, 2013 · 2270c1b · 2270c1b
2 parents 7d6229a + a2e3184
commit 2270c1b
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 11 deletions.
diff --git a/GitTfs/Commands/Init.cs b/GitTfs/Commands/Init.cs
@@ -81,8 +81,8 @@ private string[] BuildInitCommand()
 
         private void GitTfsInit(string tfsUrl, string tfsRepositoryPath)
         {
-            gitHelper.SetConfig("core.autocrlf", initOptions.GitInitAutoCrlf);
-            gitHelper.SetConfig("core.ignorecase", "false");
+            globals.Repository.SetConfig("core.autocrlf", initOptions.GitInitAutoCrlf);
+            globals.Repository.SetConfig("core.ignorecase", "false");
             globals.Repository.CreateTfsRemote(globals.RemoteId, tfsUrl, tfsRepositoryPath, remoteOptions);
         }
     }

diff --git a/GitTfs/Core/GitRepository.cs b/GitTfs/Core/GitRepository.cs
@@ -157,9 +157,14 @@ public void CreateTfsRemote(string remoteId, string tfsUrl, string tfsRepository
             _cachedRemotes = null;
         }
 
+        public void SetConfig(string key, object value)
+        {
+            _repository.Config.Set(key, value.ToString());
+        }
+
         private void SetTfsConfig(string remoteId, string subkey, object value)
         {
-            this.SetConfig(_globals.RemoteConfigKey(remoteId, subkey), value);
+            SetConfig(_globals.RemoteConfigKey(remoteId, subkey), value);
         }
 
         private void ParseRemoteConfig(TextReader stdout, IDictionary<string, IGitTfsRemote> remotes)

diff --git a/GitTfs/Core/IGitHelpers.cs b/GitTfs/Core/IGitHelpers.cs
@@ -14,12 +14,4 @@ public interface IGitHelpers
         void WrapGitCommandErrors(string exceptionMessage, Action action);
         IGitRepository MakeRepository(string dir);
     }
-
-    public static partial class Ext
-    {
-        public static void SetConfig(this IGitHelpers gitHelpers, string configKey, object value)
-        {
-            gitHelpers.CommandNoisy("config", configKey, value.ToString());
-        }
-    }
 }
diff --git a/GitTfs/Core/IGitRepository.cs b/GitTfs/Core/IGitRepository.cs
@@ -8,6 +8,7 @@ public interface IGitRepository : IGitHelpers
     {
         string GitDir { get; set; }
         string GetConfig(string key);
+        void SetConfig(string key, object value);
         IEnumerable<IGitTfsRemote> ReadAllTfsRemotes();
         IGitTfsRemote ReadTfsRemote(string remoteId);
         void /*or IGitTfsRemote*/ CreateTfsRemote(string remoteId, string tfsUrl, string tfsRepositoryPath, RemoteOptions remoteOptions);