Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support of VS2010 #1166

Merged
merged 1 commit into from Jan 28, 2018
Merged

Conversation

pmiossec
Copy link
Member

because I can't build it anymore (On my machine and on AppVeyor)

because I can't build it anymore (On my machine and on AppVeyor)
@pmiossec pmiossec merged commit fe7f5b5 into git-tfs:master Jan 28, 2018
@pmiossec pmiossec deleted the remove_vs2010_support branch March 2, 2018 13:00
@djcbhc
Copy link

djcbhc commented Dec 20, 2018

What are the implications of this change? Is it that only users of TFS with VS 2012 or later can use this version.

@pmiossec
Copy link
Member Author

pmiossec commented Dec 20, 2018

What are the implications of this change? Is it that only users of TFS with VS 2012 or later can use this version.

If I'm not wrong.... it depends....

Since VS2015, dlls required to support a new version of TFS is provided by nuget package.
So, if git-tfs can't load the different VS dlls, it will fall back to this and it should work with earlier version of TFS (but I'm note sure because not tested with TFS2010...).

Except if your TFVC collection enabled checkin policies. Because if that's the case, you should absolutely use the version of VS corresponding to the version of TFS (to be exact, git-tfs should be able to load the VS dlls corresponding). So, if you have TFS2010 with checkin policies enabled, you will have indeed to use the last version of git-tfs supporting VS2010.

But I hope that you no more use the very old version of TFS2010....

@djcbhc
Copy link

djcbhc commented Dec 24, 2018

Fortunately we don't use check-in policies, unfortunately we do use TFS2010!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants