fix: star and fork number with comma

git-touch · Mar 5, 2019 · 4a99551 · 4a99551
1 parent 5649b73
commit 4a99551
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 0 deletions.
diff --git a/lib/src/github_trending_base.dart b/lib/src/github_trending_base.dart
@@ -47,14 +47,17 @@ Future<List<TrendingRepository>> getTrendingRepositories() async {
         ?.parent
         ?.innerHtml
         ?.replaceFirst(RegExp(r'^[\s\S]*svg>'), '')
+        ?.replaceAll(',', '')
         ?.trim();
+
     var starCount = starCountStr == null ? null : int.tryParse(starCountStr);
 
     var forkCountStr = item
         .querySelector('.octicon-repo-forked')
         ?.parent
         ?.innerHtml
         ?.replaceFirst(RegExp(r'^[\s\S]*svg>'), '')
+        ?.replaceAll(',', '')
         ?.trim();
     var forkCount = forkCountStr == null ? null : int.tryParse(forkCountStr);
 

diff --git a/test/github_trending_test.dart b/test/github_trending_test.dart
@@ -20,10 +20,22 @@ void main() {
       });
     });
 
+    test('star and fork count', () {
+      // make sure at least one item has star or fork
+      // to ensure no parse error
+      var itemHasStar = items.where((item) => item.starCount != null);
+      expect(itemHasStar, isNotEmpty);
+
+      var itemHasFork = items.where((item) => item.forkCount != null);
+      expect(itemHasFork, isNotEmpty);
+    });
+
     test('primary language', () {
       items.forEach((item) {
         if (item.primaryLanguage != null) {
           expect(item.primaryLanguage.name, isNotNull);
+
+          // CSS color format
           expect(
               RegExp(r'(#\w{6})').hasMatch(item.primaryLanguage.color), isTrue);
         }