Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: selectable text #25

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

shreyas1599
Copy link
Member

@shreyas1599 shreyas1599 commented Jun 17, 2021

will close #24 and pd4d10/git-touch#204
@pd4d10 is this okay or should it be made a flag for the user to enable?

@CubeDr
Copy link

CubeDr commented Aug 3, 2021

Can this change be merged? I would love to have the highlighted code selectable.

@ShiroYacha
Copy link

It would be nice to merge this !

@Nirajn2311
Copy link

Hi, any update on this?

@krejko
Copy link

krejko commented May 28, 2023

@pd4d10 It seems there are many people who would benefit from this, myself included... would you be able to provide some insight into what's holding up the merge? Thanks!

@amake
Copy link

amake commented Sep 19, 2023

This is not the right way to do this. There are use cases where selectability is not desired.

The consumer of this package should be able to choose whether the text is selectable or not. The way to do that is by replacing RichText with Text.rich (the latter sets up the appropriate selection machinery) or supply appropriate values for selectionRegistrar and selectionColor to RichText. Either of these will let consumers determine selectivity by e.g. wrapping with SelectionArea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to make a HighlightView widget's text selectable?
8 participants