Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New branch selector UI breaks with a lot of branches #3119

Closed
ruudk opened this issue Feb 13, 2024 · 8 comments
Closed

New branch selector UI breaks with a lot of branches #3119

ruudk opened this issue Feb 13, 2024 · 8 comments

Comments

@ruudk
Copy link
Contributor

ruudk commented Feb 13, 2024

I'm on 12.0.1 and I did a git sync on an unknown branch. It asked me to select the parent.

I noticed the UI changed, but it breaks:
Screenshot 2024-02-13 at 12 21 10@2x

As you can see, I have a lot of branches, but the top of the UI is gone.

If I scroll up, I don't see it.

If I use Arrow UP to navigate, it does show the triangle move upwards, until it reaches the top (branch 36), and then nothing happens.

Also when I type main, nothing happens.

I'm on macOS using iTerm2.

@kevgo
Copy link
Contributor

kevgo commented Feb 13, 2024

Thanks for reporting this. Yes, the UI is currently missing support for scrolling. I wanted to wait until somebody actually has so many local branches before building this.

A fix is coming soon.

Just out of curiosity, why do you have so many local branches?

@ruudk
Copy link
Contributor Author

ruudk commented Feb 13, 2024

I have so many old branches, because they are old experiments. I go back there from time to time, and remove a few when no longer needed. So it just happens that I've kept a few experiments per month for the past years :) That adds up. Luckily, my git client collapses them into folders so I rarely see them.

@kevgo
Copy link
Contributor

kevgo commented Feb 13, 2024

Interesting, thanks for sharing 🙏

Possible workarounds until this is properly fixed:

  • Temporarily reduce the font size of your terminal so that all entries fit in your terminal window and you can select the right one. Most terminals have hotkeys like ctrl-shift-minus for this. After selecting the branch, you would restore the regular font size with ctrl-shift-plus.
  • The main development branch is preselected in the dialog. If that's the parent you want to select, you could just hit enter without seeing the selection.
  • Hit esc or ctrl-c to abort the dialog and run git town set-parent.

I'm sure you know all this. Just listing this here in case somebody else runs into the same problem.

@ruudk
Copy link
Contributor Author

ruudk commented Feb 13, 2024

The main development branch is preselected in the dialog. If that's the parent you want to select, you could just hit enter without seeing the selection.

This is good to know! Will try that next time, thanks!

💙 Git Town btw!

@kevgo
Copy link
Contributor

kevgo commented Feb 14, 2024

This is implemented in #3120, #3121, #3125, and #3126.

@kevgo kevgo closed this as completed Feb 14, 2024
@kevgo
Copy link
Contributor

kevgo commented Feb 14, 2024

Please update to v12.0.2 for pagination support in dialogs.

@ruudk
Copy link
Contributor Author

ruudk commented Feb 15, 2024

Just tested it out, it works perfectly! Thank you so much!

@kevgo
Copy link
Contributor

kevgo commented Feb 15, 2024

In case you missed it: cursor left/right or u/d paginates 10 lines up/down.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants