Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syntax Highlight #800

Open
avielg opened this issue Dec 30, 2021 · 3 comments
Open

Syntax Highlight #800

avielg opened this issue Dec 30, 2021 · 3 comments

Comments

@avielg
Copy link

avielg commented Dec 30, 2021

For a while, I've been dreaming about syntax highlighting in GitUp diff view, so I decided to see what it takes.
I managed to get a "poor man's highlight" working, via some regex.

  1. Is this on par with GitUp's goals / vision?
  2. Can we do this in a way that won't tank performance for large files?
  3. Can we do this well enough using regex so it doesn't make awkward mistakes too often? (or is there another way?)

I saw a previous request for this (#619) but it didn't have much attention so I'm not sure whether this is something folks are interested in?

Below are screenshots of the current hacky implementation, I am happy to keep it as a personal fork, or work with folks here to bring it to GitUp if there's demand and folks are available for code review & feedback (:

image
image

The code (note - it is very hacky, prototype level) is in this branch on my fork -> https://github.com/avielg/GitUp/tree/feature/syntax-high

@ali72x
Copy link

ali72x commented Feb 15, 2022

+1

@lucasderraugh
Copy link
Collaborator

Would be great!

@lucasderraugh
Copy link
Collaborator

lucasderraugh commented Jul 21, 2022

Going to close this out however since there is the existing open ticket. Duplicate of #619.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants