Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

update URL references to fix links & styles #113

Merged
merged 1 commit into from
Aug 24, 2017
Merged

update URL references to fix links & styles #113

merged 1 commit into from
Aug 24, 2017

Conversation

shawnajean
Copy link
Contributor

馃憢 This removes the leading / from src and hrefs in the layout files so that the links work and the styles load again since the custom domain was removed.

@matthewmccullough
Copy link
Member

Thanks for this update, @shawnajean. 鉂わ笍

Copy link
Member

@brntbeer brntbeer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what the best change or proper way forward here is. When i keep all the /s in, the site renders correctly and the links continue to work.

@shawnajean whats the best way for me to test this? When running locally, i was just starting this with jekyll serve.

@shawnajean
Copy link
Contributor Author

I based the change off of the 404 errors I'm seeing in the console on the current Pages site. With the leading /, this CSS file for example is loaded from this URL:

https://git.github.io/css/reset.css

Rather than this URL:

https://git.github.io/git-reference/css/reset.css

The gh-pages branch in my fork is built to Pages, so you can see the results here:

https://shawnajean.github.io/git-reference/

Copy link
Member

@brntbeer brntbeer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shawnajean Sorry for this sitting for so long! I'm going to approve this now and if we need to, iterate on any nuances

@brntbeer
Copy link
Member

brntbeer commented Aug 24, 2017

as per a quick convo in slack with @shawnajean, im gunna merge this! I have some additional future work that built off this coming soon to a pull request near you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants