address code review comments

git · Jun 8, 2023 · bc0eb25 · bc0eb25
1 parent 9567623
commit bc0eb25
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 7 deletions.
diff --git a/app/views/doc/credential_helpers.html.erb b/app/views/doc/credential_helpers.html.erb
@@ -11,15 +11,15 @@
 
   <ul>
     <li><a href="https://git-scm.com/docs/git-credential-store">git-credential-store</a>: saves credentials in plaintext.</li>
-    <li><a href="https://git-scm.com/docs/git-credential-cache">git-credential-cache</a>: holds credentials temporarily in process memory. <a href="https://github.com/git-for-windows/git/issues/3892">Not available on Windows</a>. (NB. Since credentials are lost when the cache expires, this is inconvenient to store personal access tokens.)</li>
+    <li><a href="https://git-scm.com/docs/git-credential-cache">git-credential-cache</a>: holds credentials temporarily in process memory. <a href="https://github.com/git-for-windows/git/issues/3892">Not available on Windows</a>. (Note that since credentials are lost when the cache expires or system restarts, this is inconvenient to store long-lived personal access tokens.)</li>
   </ul>
 
   <h2>Platform specific storage</h2>
   <p></p>
   <ul>
-    <li>git-credential-wincred: included with Git for Windows.</li>
-    <li>git-credential-osxkeychain: stores in macOS keychain.</li>
-    <li><a href="https://pkgs.org/search/?q=git-credential-libsecret">git-credential-libsecret</a>: stores in Linux secret service such as GNOME Keyring or KDE Wallet.</li>
+    <li>git-credential-osxkeychain: stores in <a href="https://support.apple.com/en-gb/guide/keychain-access/kyca1083/mac">macOS keychain</a>.</li>
+    <li>git-credential-libsecret: stores in Linux secret service such as GNOME Keyring or KDE Wallet. <a href="https://pkgs.org/search/?q=git-credential-libsecret">Packaged in many Linux distributions</a>.</li>
+    <li>git-credential-wincred: stores in <a href="https://support.microsoft.com/en-us/windows/accessing-credential-manager-1b5c916a-6a16-889f-8581-fc16e8165ac0">Windows Credential Manager</a>. Included with Git for Windows.</li>
   </ul>
 
   <h2>OAuth</h2>

diff --git a/app/views/shared/_sidebar.html.erb b/app/views/shared/_sidebar.html.erb
@@ -40,9 +40,6 @@
           <li>
             <%= link_to "Videos", "/videos", sidebar_link_options("videos") %>
           </li>
-          <li>
-            <%= link_to "Credential helpers", "/doc/credential-helpers", sidebar_link_options("credential-helpers") %>
-          </li>
           <li>
             <%= link_to "External Links", "/doc/ext", sidebar_link_options("external-links") %>
           </li>

diff --git a/app/views/shared/ref/_setup.html.erb b/app/views/shared/ref/_setup.html.erb
@@ -4,4 +4,5 @@
   <li><%= man('git-config') %></li>
   <li><%= man('git-help') %></li>
   <li><%= man('git-bugreport') %></li>
+  <%= link_to "Credential helpers", "/doc/credential-helpers", sidebar_link_options("credential-helpers") %>
 </ul>