Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The <tt> tag is obsolete #127

Closed
wants to merge 1 commit into from
Closed

The <tt> tag is obsolete #127

wants to merge 1 commit into from

Conversation

eric-wieser
Copy link
Contributor

@bry4n
Copy link
Member

bry4n commented May 24, 2012

You want to replace that with <code> for making texts displayed in monospace text.

@eric-wieser
Copy link
Contributor Author

<code> feels semantically incorrect - I wouldn't call bash code. Perhaps I'm looking at it wrongly.

At any rate, shouldn't the pre tag be doing the monospacing? See issue #128

@bry4n
Copy link
Member

bry4n commented May 24, 2012

I think tt tag was intended for formatting. See example (jsfiddle.net).

The example showed that results are different from without tt/code and tt/code.

You are right, the pre tag should make text displayed in monospace.

@eric-wieser
Copy link
Contributor Author

The fact that it was intended for formatting is exactly the reason it became obsolete. Formatting is the job of CSS.

I see no difference in the formatting of those three (the spacing is different between the ---s, but that happens if you put any tag in a pre).

@bry4n
Copy link
Member

bry4n commented May 24, 2012

I agree with you that tt is an obsolete tag.

Since I am not a designer, I think you want to send the CSS fix for formatting and the monospace font for #128.

@eric-wieser
Copy link
Contributor Author

As I mentioned in #128, I don't understand the directory structure, and can't find any CSS files to edit.

@jasonlong
Copy link
Member

I believe the tt tag is output from the asciidoc parser. @schacon / @nickh - what are your thoughts here?

@eric-wieser
Copy link
Contributor Author

Looking at the code, it appears that the asciidoc parser just uses templates/section_listing.html.erb

@nickh
Copy link
Contributor

nickh commented Jun 8, 2012

My initial goal was to output (nearly) the same HTML that the asciidoc command did, and they indeed still output tt tags. That said, in gitscm-next that's done by our own templates and not our Asciidoc parser, so we do have some freedom to make it look the way we like. I wouldn't want us to drift too far from the official HTML docs, but this seems safe to me.

yosadchuk pushed a commit to yosadchuk/git-scm.com that referenced this pull request Aug 29, 2014
skeleton for catalan translation
@peff
Copy link
Member

peff commented Dec 15, 2016

Closing as stale (the template in question isn't used anymore; we just output whatever asciidoctor says).

@peff peff closed this Dec 15, 2016
@eric-wieser
Copy link
Contributor Author

If these templates are no longer used, should they not be deleted from master?

@peff
Copy link
Member

peff commented Dec 15, 2016

If these templates are no longer used, should they not be deleted from master?

They are, aren't they?

@eric-wieser
Copy link
Contributor Author

My mistake, confused my fork with upstream

@eric-wieser eric-wieser deleted the patch-1 branch December 15, 2016 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants