Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Site design refresh #1179

Closed
wants to merge 117 commits into from
Closed

[WIP] Site design refresh #1179

wants to merge 117 commits into from

Conversation

jasonlong
Copy link
Member

@jasonlong jasonlong commented Mar 10, 2018

🚧🚧🚧🚧🚧🚧🚧🚧🚧🚧🚧🚧🚧🚧🚧🚧🚧🚧🚧🚧🚧🚧🚧🚧🚧🚧

Do not merge

This is a WIP branch with updated tooling and a refreshed site design.

🚧🚧🚧🚧🚧🚧🚧🚧🚧🚧🚧🚧🚧🚧🚧🚧🚧🚧🚧🚧🚧🚧🚧🚧🚧🚧

Project board

https://github.com/git/git-scm.com/projects/2

Heroku review app URL

https://git-scm-pr-1179.herokuapp.com


Changes

Structural

  • Responsive layout
  • Pro Git book added as top-level section

Front end

  • Tachyons CSS w/ minimal customizations/additions
  • System font stack
  • SVG icons / logos
  • Updated title tags w/ most specific info at the beginning (for easier scanning in tabs)

Performance

  • Page weight (TODO)
  • CSS stats (TODO)
  • JS reduction (TODO)

A11y

  • Improved color contrast
  • aria-labels on buttons and permalink anchors.

Tooling

  • TODO

Back end

  • TODO

Jason Long added 5 commits November 19, 2018 16:04
So that scrollbars don't render unnecessarily.
* master:
  Update _ext_tutorials.erb
  Gemfile.lock: bump rack version
Gemfile.lock Outdated
@@ -138,6 +119,10 @@ GEM
pry (~> 0.10)
public_suffix (3.0.2)
puma (3.11.3)
<<<<<<< HEAD

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conflict markers are still here :)

@pedrorijo91
Copy link
Member

@jasonlong free to pick this up again? how can we help? :)

@jasonlong
Copy link
Member Author

@pedrorijo91 Sorry again for the lack of progress here. I keep shooting myself in the foot here since each time I finally find some time to spend on this project my dev setup is broken and by the time I've gotten things fixed up, I get really busy with work again.

I'm not sure how easy it would be, but maybe someone could help get this branch updated with all of the updates to master over the past few months? If there are conflicts that need my context, those can be left for me to check into.

@pedrorijo91
Copy link
Member

totally understand @jasonlong 😅

If I remember correctly, there weren't any major changes recently. A few new books/GUIs, fixing the ES client, and some work on book translations.

will have a look during this week to help you :)

@pedrorijo91
Copy link
Member

@jasonlong sorry for taking to much time, last week was chaotic. Started merging master into v2. Still halfway, but will look at it in a couple of hours to finish it still today

@prasadgujar
Copy link

#1188 this is resolved under this PR @jasonlong @pedrorijo91 @peff @rybak @connorshea ?

@peff
Copy link
Member

peff commented Oct 2, 2019

@jasonlong There was discussion a few weeks at the last git contributors summit about setting up a community blog, that could be accessible at blog.git-scm.com or similar. Do you have any recommendations on styling to make it look consistent with the rest of the site? I.e., should people pull style elements from the existing site, or from this PR? Do you have an idea of whether you might pick this PR up again?

@jasonlong
Copy link
Member Author

Hey @peff, I should be able to help with the blog styling. Is the plan to use a standalone site? I could extract the basic styling from the "new" design into something appropriate for the blog.

And yes, I still want to see this redesign through. I'm struggling to carve out time to be able to deeply get into it.

@peff
Copy link
Member

peff commented Oct 18, 2019

@jasonlong Sorry for the slow reply. Yeah, the plan is to keep it standalone, to keep it away from the Rails complexity in the current site (and also it would probably have a larger set of people contributing to it). Right now there's a bare-bones Hugo setup at https://gitlab.com/git-scm/blog, but there are no posts yet.

@jamesramsay
Copy link

@jasonlong I'm working on trying to get a minimal version of the blog up and running linked by @peff. If you have a mockup of the new site you are working on, I could take that as inspiration so that there is a some similarity.

@pedrorijo91
Copy link
Member

there used to be a live app with the new UI, but it seems there's an error deploying to heroku currently..

@pedrorijo91 pedrorijo91 mentioned this pull request Jan 18, 2020
@pedrorijo91 pedrorijo91 mentioned this pull request Feb 20, 2020
@olegKusov
Copy link

I have some ideas about git-scm.

  1. New minimalistic and responsive design. I cant help with it.
  2. New ideas with documentation. Git is not easy. And it will be cool if we add some interactive descriptions with live branch creation tool on web page. For example , user reads something about "git revert" and on the page he can create branches and play with them with some little lessons from git-scm. I think it will be cool. Know git-scm is just hard readable documentation. And that's why we have a lot of blogs about git. We need to make official documentation easy for noobs.

@felipec
Copy link
Contributor

felipec commented May 18, 2021

Is there any link to see this redesign in action?

@pedrorijo91
Copy link
Member

closing as it's stale for a long time

@vitaly-zdanevich
Copy link

So, no new design with dark theme? :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet