Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

index.rake: build MyFirstContribution tutorial #1362

Merged
merged 1 commit into from Aug 14, 2019
Merged

index.rake: build MyFirstContribution tutorial #1362

merged 1 commit into from Aug 14, 2019

Conversation

peff
Copy link
Member

@peff peff commented Aug 14, 2019

This will be in the upcoming v2.23, and is in the same general ballpark as
SubmittingPatches. Since the release isn't out yet, this patch doesn't
do anything, but committing it now means it will kick in automatically
when v2.23 releases on Friday.

This will be in the upcoming v2.23, and is in the same general ballpark as
SubmittingPatches. Since the release isn't out yet, this patch doesn't
do anything, but committing it now means it will kick in automatically
when v2.23 releases on Friday.
@peff
Copy link
Member Author

peff commented Aug 14, 2019

You can test this by making a fake v2.23.0 tag in your local git repo, then doing a GIT_REPO=/path/to/local/repo rake local_index. That should make https://localhost:5000/docs/MyFirstContribution work.

@jnavila
Copy link
Contributor

jnavila commented Aug 14, 2019

Put aside styling of more advanced asciidoc structures (note blocks), 👍

@peff
Copy link
Member Author

peff commented Aug 14, 2019

Heh, I just quickly eyeballed the result and didn't notice the Note blocks. I agree they're not great, but they're not so horrible that you can't figure out what's going on. And in fact, it's nothing new. Look at the note at the top of https://git-scm.com/docs/git-prune, for example. Reading the asciidoc manual, it looks like these are supposed to have a nice icon in the left-hand side of the table, which is getting beyond a simple css tweak.

So I think I'll leave the styling for another day.

@peff peff merged commit 1abada1 into master Aug 14, 2019
@peff peff deleted the more-git-docs branch August 14, 2019 23:13
@peff
Copy link
Member Author

peff commented Aug 14, 2019

Hmm, actually it looks like these blocks should be styled, via

.admonitionblock {
table {
margin-bottom: 1em;
td {
padding: 0 1em;
.title {
font-weight: bold;
color: $orange;
}
&:first-child {
border-right: solid 2px $base-border-color;
}
}
}
}
.

But they don't seem to be. I wonder why.

@peff
Copy link
Member Author

peff commented Aug 14, 2019

I wonder why.

Wonder no more: #1363

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants