Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error page responsiveness, responsive sidebar updated #1651

Merged
merged 1 commit into from
Dec 1, 2021

Conversation

adsingh14
Copy link
Contributor

@adsingh14 adsingh14 commented Nov 26, 2021

Changes

  1. Fix error pages styles and turn into responsive pages.
  2. Responsive sidebar style updated.
  3. Minor change in responsive book page when open on mobile screen less than 425px width.

Context

There are two similar issues (#1316 and #1522) and nobody has reviewed those changes. Their, I've fixed those issues along with sidebar (which I didn't fix in my previous commit). Now, error pages are looking better and responsive. I've utilised errors.scss.

@adsingh14
Copy link
Contributor Author

Hi @peff ! I've fixed some pages UI and sidebar UX. Please have a look at it.

@peff peff temporarily deployed to git-scm-pr-1651 December 1, 2021 16:57 Inactive
@peff
Copy link
Member

peff commented Dec 1, 2021

Minor change in responsive book page when open on mobile.

I had trouble reviewing this part, because I didn't know exactly what you were trying to fix. From looking at the result and at #1650, it looks like this addresses the issue where scrolling down in a long page and revealing the sidebar should show the top of the sidebar content. And it seems to improve that for me (using firefox for android).

@adsingh14
Copy link
Contributor Author

I had trouble reviewing this part, because I didn't know exactly what you were trying to fix.

That's a patch for smaller screens (425px or less). When we open the Book page, the header misaligned the layout (top most part of book with images).

@adsingh14 adsingh14 deleted the error_pages_n_css branch December 2, 2021 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants