Skip to content

Commit

Permalink
git-p4 shouldn't attempt to store symlinks in LFS
Browse files Browse the repository at this point in the history
git-p4.py would attempt to put a symlink in LFS if its file extension
matched git-p4.largeFileExtensions.

Git LFS doesn't store symlinks because smudge/clean filters don't handle
symlinks. They never get passed to the filter process nor the
smudge/clean filters, nor could that occur without a change to the
protocol or command-line interface. Unless Git learned how to send them
to the filters, Git LFS would have a hard time using them in any useful
way.

Git LFS's goal is to move large files out of the repository history, and
symlinks are functionally limited to 4 KiB or a similar size on most
systems.

Signed-off-by: Matthew McClain <mmcclain@noprivs.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
Matthew McClain authored and gitster committed Oct 19, 2023
1 parent 43c8a30 commit 10c89a0
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions git-p4.py
Expand Up @@ -1522,6 +1522,10 @@ def processContent(self, git_mode, relPath, contents):
file is stored in the large file system and handles all necessary
steps.
"""
# symlinks aren't processed by smudge/clean filters
if git_mode == "120000":
return (git_mode, contents)

if self.exceedsLargeFileThreshold(relPath, contents) or self.hasLargeFileExtension(relPath):
contentTempFile = self.generateTempFile(contents)
pointer_git_mode, contents, localLargeFile = self.generatePointer(contentTempFile)
Expand Down

0 comments on commit 10c89a0

Please sign in to comment.