Skip to content

Commit

Permalink
Merge branch 'sg/commit-graph-progress-fix' into master
Browse files Browse the repository at this point in the history
The code to produce progress output from "git commit-graph --write"
had a few breakages, which have been fixed.

* sg/commit-graph-progress-fix:
  commit-graph: fix "Writing out commit graph" progress counter
  commit-graph: fix progress of reachable commits
  • Loading branch information
gitster committed Jul 15, 2020
2 parents 05920f0 + 150cd3b commit 12f5eb9
Showing 1 changed file with 5 additions and 22 deletions.
27 changes: 5 additions & 22 deletions commit-graph.c
Expand Up @@ -1149,23 +1149,14 @@ static void write_graph_chunk_bloom_indexes(struct hashfile *f,
struct commit **list = ctx->commits.list;
struct commit **last = ctx->commits.list + ctx->commits.nr;
uint32_t cur_pos = 0;
struct progress *progress = NULL;
int i = 0;

if (ctx->report_progress)
progress = start_delayed_progress(
_("Writing changed paths Bloom filters index"),
ctx->commits.nr);

while (list < last) {
struct bloom_filter *filter = get_bloom_filter(ctx->r, *list, 0);
cur_pos += filter->len;
display_progress(progress, ++i);
display_progress(ctx->progress, ++ctx->progress_cnt);
hashwrite_be32(f, cur_pos);
list++;
}

stop_progress(&progress);
}

static void write_graph_chunk_bloom_data(struct hashfile *f,
Expand All @@ -1174,26 +1165,17 @@ static void write_graph_chunk_bloom_data(struct hashfile *f,
{
struct commit **list = ctx->commits.list;
struct commit **last = ctx->commits.list + ctx->commits.nr;
struct progress *progress = NULL;
int i = 0;

if (ctx->report_progress)
progress = start_delayed_progress(
_("Writing changed paths Bloom filters data"),
ctx->commits.nr);

hashwrite_be32(f, settings->hash_version);
hashwrite_be32(f, settings->num_hashes);
hashwrite_be32(f, settings->bits_per_entry);

while (list < last) {
struct bloom_filter *filter = get_bloom_filter(ctx->r, *list, 0);
display_progress(progress, ++i);
display_progress(ctx->progress, ++ctx->progress_cnt);
hashwrite(f, filter->data, filter->len * sizeof(unsigned char));
list++;
}

stop_progress(&progress);
}

static int oid_compare(const void *_a, const void *_b)
Expand Down Expand Up @@ -1423,12 +1405,13 @@ int write_commit_graph_reachable(struct object_directory *odb,
_("Collecting referenced commits"), 0);

for_each_ref(add_ref_to_set, &data);

stop_progress(&data.progress);

result = write_commit_graph(odb, NULL, &commits,
flags, split_opts);

oidset_clear(&commits);
if (data.progress)
stop_progress(&data.progress);
return result;
}

Expand Down

0 comments on commit 12f5eb9

Please sign in to comment.