Skip to content

Commit

Permalink
rebase--interactive: move transform_todo_file() to rebase--interactive.c
Browse files Browse the repository at this point in the history
As transform_todo_file() is only needed inside of rebase--interactive.c,
it is moved there from sequencer.c.

Signed-off-by: Alban Gruin <alban.gruin@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
  • Loading branch information
agrn authored and gitster committed Jan 29, 2019
1 parent be92890 commit 30faf27
Show file tree
Hide file tree
Showing 3 changed files with 25 additions and 25 deletions.
26 changes: 25 additions & 1 deletion builtin/rebase--interactive.c
Expand Up @@ -35,6 +35,30 @@ static int edit_todo_file(unsigned flags)
return 0;
}

static int transform_todo_file(unsigned flags)
{
const char *todo_file = rebase_path_todo();
struct todo_list todo_list = TODO_LIST_INIT;
int res;

if (strbuf_read_file(&todo_list.buf, todo_file, 0) < 0)
return error_errno(_("could not read '%s'."), todo_file);

if (todo_list_parse_insn_buffer(the_repository, todo_list.buf.buf,
&todo_list)) {
todo_list_release(&todo_list);
return error(_("unusable todo list: '%s'"), todo_file);
}

res = todo_list_write_to_file(the_repository, &todo_list, todo_file,
NULL, NULL, -1, flags);
todo_list_release(&todo_list);

if (res)
return error_errno(_("could not write '%s'."), todo_file);
return 0;
}

static int get_revision_ranges(const char *upstream, const char *onto,
const char **head_hash,
char **revisions, char **shortrevisions)
Expand Down Expand Up @@ -277,7 +301,7 @@ int cmd_rebase__interactive(int argc, const char **argv, const char *prefix)
}
case SHORTEN_OIDS:
case EXPAND_OIDS:
ret = transform_todo_file(the_repository, flags);
ret = transform_todo_file(flags);
break;
case CHECK_TODO_LIST:
ret = check_todo_list_from_file(the_repository);
Expand Down
23 changes: 0 additions & 23 deletions sequencer.c
Expand Up @@ -4648,29 +4648,6 @@ int todo_list_write_to_file(struct repository *r, struct todo_list *todo_list,
return res;
}

int transform_todo_file(struct repository *r, unsigned flags)
{
const char *todo_file = rebase_path_todo();
struct todo_list todo_list = TODO_LIST_INIT;
int res;

if (strbuf_read_file(&todo_list.buf, todo_file, 0) < 0)
return error_errno(_("could not read '%s'."), todo_file);

if (todo_list_parse_insn_buffer(r, todo_list.buf.buf, &todo_list)) {
todo_list_release(&todo_list);
return error(_("unusable todo list: '%s'"), todo_file);
}

res = todo_list_write_to_file(r, &todo_list, todo_file,
NULL, NULL, -1, flags);
todo_list_release(&todo_list);

if (res)
return error_errno(_("could not write '%s'."), todo_file);
return 0;
}

static const char edit_todo_list_advice[] =
N_("You can fix this with 'git rebase --edit-todo' "
"and then run 'git rebase --continue'.\n"
Expand Down
1 change: 0 additions & 1 deletion sequencer.h
Expand Up @@ -145,7 +145,6 @@ int sequencer_make_script(struct repository *r, struct strbuf *out, int argc,

int sequencer_add_exec_commands(struct repository *r,
struct string_list *commands);
int transform_todo_file(struct repository *r, unsigned flags);
int check_todo_list_from_file(struct repository *r);
int complete_action(struct repository *r, struct replay_opts *opts, unsigned flags,
const char *shortrevisions, const char *onto_name,
Expand Down

0 comments on commit 30faf27

Please sign in to comment.